]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
workspaceThumbnails: Add missing return values to later handlers
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 3 Nov 2025 11:50:34 +0000 (12:50 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 24 Nov 2025 13:42:59 +0000 (14:42 +0100)
MetaLaters are source functions, and should therefore return a bool
to indicate whether the source should be removed or continue.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3950>
(cherry picked from commit 948f1a7eeb9ea0cbe4d54831d94db9bf4d0ce7cd)

js/ui/workspaceThumbnail.js

index 1ccabd5e76bf29509633af5c4e6ca9b55e00bf95..bb15926a403505a9f87fe6d3d30aeca7ae7056f2 100644 (file)
@@ -1188,7 +1188,10 @@ export const ThumbnailsBox = GObject.registerClass({
 
         const laters = global.compositor.get_laters();
         this._updateStateId = laters.add(
-            Meta.LaterType.BEFORE_REDRAW, () => this._updateStates());
+            Meta.LaterType.BEFORE_REDRAW, () => {
+                this._updateStates();
+                return GLib.SOURCE_REMOVE;
+            });
     }
 
     _unqueueUpdateStates() {
@@ -1345,6 +1348,7 @@ export const ThumbnailsBox = GObject.registerClass({
                     Meta.LaterType.BEFORE_REDRAW, () => {
                         this._dropPlaceholder.hide();
                         delete this._dropPlaceholderLater;
+                        return GLib.SOURCE_REMOVE;
                     });
             }
         }
@@ -1381,6 +1385,7 @@ export const ThumbnailsBox = GObject.registerClass({
                         Meta.LaterType.BEFORE_REDRAW, () => {
                             this._dropPlaceholder.show();
                             delete this._dropPlaceholderLater;
+                            return GLib.SOURCE_REMOVE;
                         });
                 }
                 x += placeholderWidth + spacing;